부산대 Android_김정희_6주차 과제_1단계 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # README.md # app/build.gradle.kts # app/src/main/AndroidManifest.xml # app/src/main/res/layout/activity_main.xml # app/src/main/res/values/strings.xml # build.gradle.kts # gradle/wrapper/gradle-wrapper.properties # settings.gradle.kts
LeeOhHyung
pushed a commit
that referenced
this pull request
Jul 30, 2024
* Initial commit * Initial commit * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Docs: Update README.md * Feat: Create item_view * Feat: Modify main view * Feat: Implement search list * Feat: Complete saved element view * Feat: Complete save action * Feat: Add persistent save function * 부산대 Android_김현민_2주차_과제_Step1 (#2) * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Design: Modify save element design * Update README.md * Initial commit * Fix: Fix Week2 error * Docs: Update README.md Step1 README * Feat: Add initial settings * Feat: Add Document data class * Feat: Add RetrofitService interface * Refactor: Delete DB code * Feat: Add search function using API * Feat: Separate CategoryGroupCode * Docs: Update step2 README.md * Feat: complete initial project setup * Feat: Add mapview and map function * Fix: resolve errors * Chore: Update network security configuration * Fix: Resolve windows emulator issue * Style: Update mapview design * 부산대 Android_김현민 3주차 과제 Step0 (#19) * Initial commit * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Docs: Update README.md * Feat: Create item_view * Feat: Modify main view * Feat: Implement search list * Feat: Complete saved element view * Feat: Complete save action * Feat: Add persistent save function * 부산대 Android_김현민_2주차_과제_Step1 (#2) * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Design: Modify save element design * Update README.md --------- Co-authored-by: MyStoryG <[email protected]> * Fix: Reflect feedback * Fix: Resolve error * 부산대 Android_김현민 4주차 과제 Step0 (#16) * Initial commit * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Docs: Update README.md * Feat: Create item_view * Feat: Modify main view * Feat: Implement search list * Feat: Complete saved element view * Feat: Complete save action * Feat: Add persistent save function * 부산대 Android_김현민_2주차_과제_Step1 (#2) * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Design: Modify save element design * Update README.md * Initial commit * Fix: Fix Week2 error * Docs: Update README.md Step1 README * Feat: Add initial settings * Feat: Add Document data class * Feat: Add RetrofitService interface * Refactor: Delete DB code * Feat: Add search function using API * Feat: Separate CategoryGroupCode * Docs: Update step2 README.md * Feat: complete initial project setup * Feat: Add mapview and map function * Fix: resolve errors * Chore: Update network security configuration * Fix: Resolve windows emulator issue * Style: Update mapview design * 부산대 Android_김현민 3주차 과제 Step0 (#19) * Initial commit * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Docs: Update README.md * Feat: Create item_view * Feat: Modify main view * Feat: Implement search list * Feat: Complete saved element view * Feat: Complete save action * Feat: Add persistent save function * 부산대 Android_김현민_2주차_과제_Step1 (#2) * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Design: Modify save element design * Update README.md --------- Co-authored-by: MyStoryG <[email protected]> * Fix: Reflect feedback * Fix: Resolve error --------- Co-authored-by: MyStoryG <[email protected]> * Docs: Update README.md * Feat: Add location marker * Feat: Add camera movement function * Feat: Add bottom sheet dialog * Feat: Add initial camera location function * Refactor: Resolve initial camera issue and search issue * Feat: Add map error event * Design: Modify UI design * Refactor: Separate function and write annotations * Docs: Update README.md * Feat: Add save item click function * Feat: Add keyword search function * Refactor: Reflect step1 feedback * Initial commit * Feat: Add dependencies * Test: Add map activity ui test * Test: Add main activity ui test * Test: Add main activity unit test * Test: Add map activity unit test * 부산대 Android_김현민 4주차 과제 Step1 (#33) * Initial commit * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Docs: Update README.md * Feat: Create item_view * Feat: Modify main view * Feat: Implement search list * Feat: Complete saved element view * Feat: Complete save action * Feat: Add persistent save function * 부산대 Android_김현민_2주차_과제_Step1 (#2) * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Design: Modify save element design * Update README.md * Initial commit * Fix: Fix Week2 error * Docs: Update README.md Step1 README * Feat: Add initial settings * Feat: Add Document data class * Feat: Add RetrofitService interface * Refactor: Delete DB code * Feat: Add search function using API * Feat: Separate CategoryGroupCode * Docs: Update step2 README.md * Feat: complete initial project setup * Feat: Add mapview and map function * Fix: resolve errors * Chore: Update network security configuration * Fix: Resolve windows emulator issue * Style: Update mapview design * 부산대 Android_김현민 3주차 과제 Step0 (#19) * Initial commit * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Docs: Update README.md * Feat: Create item_view * Feat: Modify main view * Feat: Implement search list * Feat: Complete saved element view * Feat: Complete save action * Feat: Add persistent save function * 부산대 Android_김현민_2주차_과제_Step1 (#2) * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Design: Modify save element design * Update README.md --------- Co-authored-by: MyStoryG <[email protected]> * Fix: Reflect feedback * Fix: Resolve error * Docs: Update README.md * Feat: Add location marker * Feat: Add camera movement function * Feat: Add bottom sheet dialog * Feat: Add initial camera location function * Refactor: Resolve initial camera issue and search issue * Feat: Add map error event * Design: Modify UI design * Refactor: Separate function and write annotations * Docs: Update README.md * Feat: Add save item click function * Feat: Add keyword search function * Update README.md --------- Co-authored-by: MyStoryG <[email protected]> * Fix: Fix conflict error * Chore: Add dependency and grouping * 부산대 Android_김현민 5주차 과제 Step0 (#6) * Initial commit * Initial commit * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Docs: Update README.md * Feat: Create item_view * Feat: Modify main view * Feat: Implement search list * Feat: Complete saved element view * Feat: Complete save action * Feat: Add persistent save function * 부산대 Android_김현민_2주차_과제_Step1 (#2) * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Design: Modify save element design * Update README.md * Initial commit * Fix: Fix Week2 error * Docs: Update README.md Step1 README * Feat: Add initial settings * Feat: Add Document data class * Feat: Add RetrofitService interface * Refactor: Delete DB code * Feat: Add search function using API * Feat: Separate CategoryGroupCode * Docs: Update step2 README.md * Feat: complete initial project setup * Feat: Add mapview and map function * Fix: resolve errors * Chore: Update network security configuration * Fix: Resolve windows emulator issue * Style: Update mapview design * 부산대 Android_김현민 3주차 과제 Step0 (#19) * Initial commit * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Docs: Update README.md * Feat: Create item_view * Feat: Modify main view * Feat: Implement search list * Feat: Complete saved element view * Feat: Complete save action * Feat: Add persistent save function * 부산대 Android_김현민_2주차_과제_Step1 (#2) * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Design: Modify save element design * Update README.md --------- Co-authored-by: MyStoryG <[email protected]> * Fix: Reflect feedback * Fix: Resolve error * 부산대 Android_김현민 4주차 과제 Step0 (#16) * Initial commit * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Docs: Update README.md * Feat: Create item_view * Feat: Modify main view * Feat: Implement search list * Feat: Complete saved element view * Feat: Complete save action * Feat: Add persistent save function * 부산대 Android_김현민_2주차_과제_Step1 (#2) * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Design: Modify save element design * Update README.md * Initial commit * Fix: Fix Week2 error * Docs: Update README.md Step1 README * Feat: Add initial settings * Feat: Add Document data class * Feat: Add RetrofitService interface * Refactor: Delete DB code * Feat: Add search function using API * Feat: Separate CategoryGroupCode * Docs: Update step2 README.md * Feat: complete initial project setup * Feat: Add mapview and map function * Fix: resolve errors * Chore: Update network security configuration * Fix: Resolve windows emulator issue * Style: Update mapview design * 부산대 Android_김현민 3주차 과제 Step0 (#19) * Initial commit * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Docs: Update README.md * Feat: Create item_view * Feat: Modify main view * Feat: Implement search list * Feat: Complete saved element view * Feat: Complete save action * Feat: Add persistent save function * 부산대 Android_김현민_2주차_과제_Step1 (#2) * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Design: Modify save element design * Update README.md --------- Co-authored-by: MyStoryG <[email protected]> * Fix: Reflect feedback * Fix: Resolve error --------- Co-authored-by: MyStoryG <[email protected]> * Docs: Update README.md * Feat: Add location marker * Feat: Add camera movement function * Feat: Add bottom sheet dialog * Feat: Add initial camera location function * Refactor: Resolve initial camera issue and search issue * Feat: Add map error event * Design: Modify UI design * Refactor: Separate function and write annotations * Docs: Update README.md * Feat: Add save item click function * Feat: Add keyword search function * Refactor: Reflect step1 feedback * Feat: Add dependencies * Test: Add map activity ui test * Test: Add main activity ui test * Test: Add main activity unit test * Test: Add map activity unit test * 부산대 Android_김현민 4주차 과제 Step1 (#33) * Initial commit * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Docs: Update README.md * Feat: Create item_view * Feat: Modify main view * Feat: Implement search list * Feat: Complete saved element view * Feat: Complete save action * Feat: Add persistent save function * 부산대 Android_김현민_2주차_과제_Step1 (#2) * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Design: Modify save element design * Update README.md * Initial commit * Fix: Fix Week2 error * Docs: Update README.md Step1 README * Feat: Add initial settings * Feat: Add Document data class * Feat: Add RetrofitService interface * Refactor: Delete DB code * Feat: Add search function using API * Feat: Separate CategoryGroupCode * Docs: Update step2 README.md * Feat: complete initial project setup * Feat: Add mapview and map function * Fix: resolve errors * Chore: Update network security configuration * Fix: Resolve windows emulator issue * Style: Update mapview design * 부산대 Android_김현민 3주차 과제 Step0 (#19) * Initial commit * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Docs: Update README.md * Feat: Create item_view * Feat: Modify main view * Feat: Implement search list * Feat: Complete saved element view * Feat: Complete save action * Feat: Add persistent save function * 부산대 Android_김현민_2주차_과제_Step1 (#2) * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Design: Modify save element design * Update README.md --------- Co-authored-by: MyStoryG <[email protected]> * Fix: Reflect feedback * Fix: Resolve error * Docs: Update README.md * Feat: Add location marker * Feat: Add camera movement function * Feat: Add bottom sheet dialog * Feat: Add initial camera location function * Refactor: Resolve initial camera issue and search issue * Feat: Add map error event * Design: Modify UI design * Refactor: Separate function and write annotations * Docs: Update README.md * Feat: Add save item click function * Feat: Add keyword search function * Update README.md --------- Co-authored-by: MyStoryG <[email protected]> * Fix: Fix conflict error * Chore: Add dependency and grouping --------- Co-authored-by: MyStoryG <[email protected]> * Chore: Edit grouping * Refactor: Change database to Room * Fix: Resolve data integrity error * Refactor: Apply dependency injection dependency injection about network * Refactor: Apply dependency injection dependency injection about map utility * Refactor: Apply dependency injection dependency injection about map search service * Chore: Edit grouping * Refactor: Apply dependency injection dependency injection about search save service * Refactor: Apply dependency injection dependency injection about bottomsheet * Fix: Remove test code error Resolve errors caused by code modification during refactoring process * Refactor: Reflect step1 feedback * Chore: Add initial settings * Refactor: Apply databinding in MainActivity * Refactor: Apply MVVM in error activity Utilize LiveData and DataBinding * 부산대 Android_김현민 5주차 과제 Step1 (#25) * Initial commit * Initial commit * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Docs: Update README.md * Feat: Create item_view * Feat: Modify main view * Feat: Implement search list * Feat: Complete saved element view * Feat: Complete save action * Feat: Add persistent save function * 부산대 Android_김현민_2주차_과제_Step1 (#2) * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Design: Modify save element design * Update README.md * Initial commit * Fix: Fix Week2 error * Docs: Update README.md Step1 README * Feat: Add initial settings * Feat: Add Document data class * Feat: Add RetrofitService interface * Refactor: Delete DB code * Feat: Add search function using API * Feat: Separate CategoryGroupCode * Docs: Update step2 README.md * Feat: complete initial project setup * Feat: Add mapview and map function * Fix: resolve errors * Chore: Update network security configuration * Fix: Resolve windows emulator issue * Style: Update mapview design * 부산대 Android_김현민 3주차 과제 Step0 (#19) * Initial commit * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Docs: Update README.md * Feat: Create item_view * Feat: Modify main view * Feat: Implement search list * Feat: Complete saved element view * Feat: Complete save action * Feat: Add persistent save function * 부산대 Android_김현민_2주차_과제_Step1 (#2) * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Design: Modify save element design * Update README.md --------- Co-authored-by: MyStoryG <[email protected]> * Fix: Reflect feedback * Fix: Resolve error * 부산대 Android_김현민 4주차 과제 Step0 (#16) * Initial commit * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Docs: Update README.md * Feat: Create item_view * Feat: Modify main view * Feat: Implement search list * Feat: Complete saved element view * Feat: Complete save action * Feat: Add persistent save function * 부산대 Android_김현민_2주차_과제_Step1 (#2) * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Design: Modify save element design * Update README.md * Initial commit * Fix: Fix Week2 error * Docs: Update README.md Step1 README * Feat: Add initial settings * Feat: Add Document data class * Feat: Add RetrofitService interface * Refactor: Delete DB code * Feat: Add search function using API * Feat: Separate CategoryGroupCode * Docs: Update step2 README.md * Feat: complete initial project setup * Feat: Add mapview and map function * Fix: resolve errors * Chore: Update network security configuration * Fix: Resolve windows emulator issue * Style: Update mapview design * 부산대 Android_김현민 3주차 과제 Step0 (#19) * Initial commit * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Docs: Update README.md * Feat: Create item_view * Feat: Modify main view * Feat: Implement search list * Feat: Complete saved element view * Feat: Complete save action * Feat: Add persistent save function * 부산대 Android_김현민_2주차_과제_Step1 (#2) * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Design: Modify save element design * Update README.md --------- Co-authored-by: MyStoryG <[email protected]> * Fix: Reflect feedback * Fix: Resolve error --------- Co-authored-by: MyStoryG <[email protected]> * Docs: Update README.md * Feat: Add location marker * Feat: Add camera movement function * Feat: Add bottom sheet dialog * Feat: Add initial camera location function * Refactor: Resolve initial camera issue and search issue * Feat: Add map error event * Design: Modify UI design * Refactor: Separate function and write annotations * Docs: Update README.md * Feat: Add save item click function * Feat: Add keyword search function * Refactor: Reflect step1 feedback * Feat: Add dependencies * Test: Add map activity ui test * Test: Add main activity ui test * Test: Add main activity unit test * Test: Add map activity unit test * 부산대 Android_김현민 4주차 과제 Step1 (#33) * Initial commit * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Docs: Update README.md * Feat: Create item_view * Feat: Modify main view * Feat: Implement search list * Feat: Complete saved element view * Feat: Complete save action * Feat: Add persistent save function * 부산대 Android_김현민_2주차_과제_Step1 (#2) * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Design: Modify save element design * Update README.md * Initial commit * Fix: Fix Week2 error * Docs: Update README.md Step1 README * Feat: Add initial settings * Feat: Add Document data class * Feat: Add RetrofitService interface * Refactor: Delete DB code * Feat: Add search function using API * Feat: Separate CategoryGroupCode * Docs: Update step2 README.md * Feat: complete initial project setup * Feat: Add mapview and map function * Fix: resolve errors * Chore: Update network security configuration * Fix: Resolve windows emulator issue * Style: Update mapview design * 부산대 Android_김현민 3주차 과제 Step0 (#19) * Initial commit * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Docs: Update README.md * Feat: Create item_view * Feat: Modify main view * Feat: Implement search list * Feat: Complete saved element view * Feat: Complete save action * Feat: Add persistent save function * 부산대 Android_김현민_2주차_과제_Step1 (#2) * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Design: Modify save element design * Update README.md --------- Co-authored-by: MyStoryG <[email protected]> * Fix: Reflect feedback * Fix: Resolve error * Docs: Update README.md * Feat: Add location marker * Feat: Add camera movement function * Feat: Add bottom sheet dialog * Feat: Add initial camera location function * Refactor: Resolve initial camera issue and search issue * Feat: Add map error event * Design: Modify UI design * Refactor: Separate function and write annotations * Docs: Update README.md * Feat: Add save item click function * Feat: Add keyword search function * Update README.md --------- Co-authored-by: MyStoryG <[email protected]> * Fix: Fix conflict error * Chore: Add dependency and grouping * Chore: Edit grouping * Refactor: Change database to Room * Fix: Resolve data integrity error * Refactor: Apply dependency injection dependency injection about network * Refactor: Apply dependency injection dependency injection about map utility * Refactor: Apply dependency injection dependency injection about map search service * Chore: Edit grouping * Refactor: Apply dependency injection dependency injection about search save service * Refactor: Apply dependency injection dependency injection about bottomsheet * Fix: Remove test code error Resolve errors caused by code modification during refactoring process --------- Co-authored-by: MyStoryG <[email protected]> * Refactor: Change asynchronous to coroutine * Refactor: Apply MVVM in map activity Utilize LiveData and DataBinding * Chore: Modify error activity code * Refactor: Apply MVVM in main activity Utilize LiveData and DataBinding * Chore: Prepare step0 * Docs: Update README.md * Feat: Add splash screen * Refactor: Apply MVVM in splash activity * Refactor: Reflect week5 feedback --------- Co-authored-by: MyStoryG <[email protected]>
LeeOhHyung
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
@lovelhee 6주차 step1 과제도 고생많으셨습니다!
6주차는 RemoteConfig 적용하는것이라 금방 하셨네요. 코멘트 확인후 수정하신다면 step2에 반영해주셔도 괜찮습니다!
Comment on lines
+25
to
+48
| init { | ||
| setupRemoteConfig() | ||
| fetchRemoteConfig() | ||
| } | ||
|
|
||
| private fun setupRemoteConfig() { | ||
| val configSettings = remoteConfigSettings { | ||
| minimumFetchIntervalInSeconds = 0 | ||
| } | ||
| remoteConfig.setConfigSettingsAsync(configSettings) | ||
| } | ||
|
|
||
| private fun fetchRemoteConfig() { | ||
| viewModelScope.launch { | ||
| remoteConfig.fetchAndActivate() | ||
| .addOnCompleteListener { task -> | ||
| if (task.isSuccessful) { | ||
| handleRemoteConfig() | ||
| } else { | ||
| Log.d("SplashScreenViewModel", "Fetch failed") | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
remoteConfig 에서 값을 가져와서 처리하는 로직은 정상적으로 작성해주셨습니다.
조금더 개선하면 좋을 부분이요. RemoteConfig도 결국 원격 저장소에서 데이터를 가져오는 관점에서 data layer 및 model의 영역이라고 볼수 있습니다. 따라서 ViewModel 이나 Repository 같은 곳에서 데이터를 조회한 후에 UI에서 전달받는 형태가 조금더 좋을것 같긴합니다 .
There was a problem hiding this comment.
감사합니다! 그런 부분까지 생각하지 못했는데 새로운 관점을 알게 되었네요!! 적용해보겠습니다.
Comment on lines
+40
to
+43
| Handler(Looper.getMainLooper()).postDelayed({ | ||
| startActivity(Intent(this, MapActivity::class.java)) | ||
| finish() | ||
| }, 3000) |
There was a problem hiding this comment.
MapActivity를 띄우는데 handler로 3초 딜레이를 주신 이유가 있을까요.
약간 늦게 뜨는걸 의도한 것이라면, ViewModelScope.launch 수행할때 RemoteConfig 값을 조금 늦게 확인하도록 하는방법이 어덜까 합니다.
viewModelScope.launch {
delay(3000L)
...
}There was a problem hiding this comment.
저에게는 가끔 에뮬레이터가 버벅이며 늦게 실행되어서 Splash Screen에 아이콘이 잘 들어왔는지, 메시지가 잘 처리되었는지 확인되기도 전에 MapActivity로 갑자기 휙 넘어가는 경우가 있어 지연을 주고싶었습니다.
구글링을 통해 해당 방법을 찾았는데, 더 좋은 방법을 알려주셔서 감사합니다!
(이 부분 작성할 때 제가 찾았던 자료도 살짝쿵 첨부하고 갑니다 ㅎㅎ)
https://dailycoding365.tistory.com/entry/%EC%95%88%EB%93%9C%EB%A1%9C%EC%9D%B4%EB%93%9C-Splash-%ED%99%94%EB%A9%B4-%EA%B5%AC%ED%98%84%ED%95%98%EA%B8%B0
Comment on lines
+30
to
+41
| <TextView | ||
| android:id="@+id/tvServiceMessage" | ||
| android:layout_width="match_parent" | ||
| android:layout_height="wrap_content" | ||
| android:text="@{viewModel.serviceMessage}" | ||
| android:textColor="#999999" | ||
| app:layout_constraintBottom_toBottomOf="parent" | ||
| app:layout_constraintEnd_toEndOf="parent" | ||
| app:layout_constraintStart_toStartOf="parent" | ||
| android:gravity="center" | ||
| android:layout_marginBottom="50dp" | ||
| android:visibility="@{viewModel.serviceState.equals(`ON_SERVICE`) ? View.GONE : View.VISIBLE}"/> |
There was a problem hiding this comment.
text를 넣어주는 코드는 Activity의 showServiceMessage() 메소드에서도 하고 있는것 같네요.
Activity or XML 중에 한곳에서 하도록 통일하는것은 어떨까합니다.
There was a problem hiding this comment.
state가 ON_SERVICE가 아닐 때, showServiceMessage()가 호출되며 로그를 띄우는 등의 기능을 하니까 Activity에서 하도록 통일해보려고 합니다 ... !!
omjoonkim
pushed a commit
that referenced
this pull request
Jul 31, 2024
* Initial commit * 충남대 Android_김선규 5주차 Step0 (#33) * Initial commit * 충남대 Android_김선규 4주차 Step0 (#10) * Initial commit * Merge : android-map-keyword into android-map-search (#8) * 충남대 Android_김선규 3주차 과제 Step1 (#47) * docs: add step1 requirements * chore: set for using android api * style: rename id in layout * feat: remove storeInfo for using api * feat: add connecting api for searching * style: rename variable name proper * 충남대 Android_김선규 3주차 과제 Step2 (#85) * style: function rename and split * feat: Change function to fit coroutine * docs: add step2 requirements * style: move from main to sub file * chore: set it up to work in the right environment * feat: display kakao map, when app is started --------- Co-authored-by: MyStoryG <[email protected]> * 충남대 Android_김선규 4주차 Step 1 제출 (#47) * docs: add week 4 step 1 requirements * feat: add searching by saved search keyword * chore: relocate files proper * feat: modify adapter to make clean code * feat: add image for marker * feat: add layout for displaying bottom sheet * feat: add parcelabel for easy to send data * feat: add displaying search result * refactor: modify class structure * feat: add error screen and reload button * feat: add saving and loading last position when app is closed, save last position when app is opened, load last position * 충남대 Android_김선규 4주차 Step2 수정 (#73) * style: rename variable name * feat: add viewModel and Repository for saving last position * refactor: classify in more detail * test: add android UI test * chore: add mockk test dependency * test: add ViewModel test * chore: add testOptions * test: modify android ui test --------- Co-authored-by: MyStoryG <[email protected]> * 충남대 Android_김선규 4주차 Step0 (#10) * Initial commit * Merge : android-map-keyword into android-map-search (#8) * 충남대 Android_김선규 3주차 과제 Step1 (#47) * docs: add step1 requirements * chore: set for using android api * style: rename id in layout * feat: remove storeInfo for using api * feat: add connecting api for searching * style: rename variable name proper * 충남대 Android_김선규 3주차 과제 Step2 (#85) * style: function rename and split * feat: Change function to fit coroutine * docs: add step2 requirements * style: move from main to sub file * chore: set it up to work in the right environment * feat: display kakao map, when app is started --------- Co-authored-by: MyStoryG <[email protected]> * 충남대 Android_김선규 4주차 Step 1 제출 (#47) * docs: add week 4 step 1 requirements * feat: add searching by saved search keyword * chore: relocate files proper * feat: modify adapter to make clean code * feat: add image for marker * feat: add layout for displaying bottom sheet * feat: add parcelabel for easy to send data * feat: add displaying search result * refactor: modify class structure * feat: add error screen and reload button * feat: add saving and loading last position when app is closed, save last position when app is opened, load last position * 충남대 Android_김선규 4주차 Step2 수정 (#73) * style: rename variable name * feat: add viewModel and Repository for saving last position * refactor: classify in more detail * test: add android UI test * chore: add mockk test dependency * test: add ViewModel test * chore: add testOptions * test: modify android ui test * chore: add Room dependency * feat: change SQLite to Room about DB * chore: add Hilt dependency * feat: add Hilt for MVVM * chore: add dataBinding * feat: add dataBinding * feat: modify about Hilt --------- Co-authored-by: MyStoryG <[email protected]>
kimseongyu
added a commit
to kimseongyu/android-map-notification
that referenced
this pull request
Jul 31, 2024
* Initial commit * 충남대 Android_김선규 4주차 Step0 (kakao-tech-campus-2nd-step2#10) * Initial commit * Merge : android-map-keyword into android-map-search (kakao-tech-campus-2nd-step2#8) * 충남대 Android_김선규 3주차 과제 Step1 (kakao-tech-campus-2nd-step2#47) * docs: add step1 requirements * chore: set for using android api * style: rename id in layout * feat: remove storeInfo for using api * feat: add connecting api for searching * style: rename variable name proper * 충남대 Android_김선규 3주차 과제 Step2 (kakao-tech-campus-2nd-step2#85) * style: function rename and split * feat: Change function to fit coroutine * docs: add step2 requirements * style: move from main to sub file * chore: set it up to work in the right environment * feat: display kakao map, when app is started --------- Co-authored-by: MyStoryG <[email protected]> * 충남대 Android_김선규 4주차 Step 1 제출 (kakao-tech-campus-2nd-step2#47) * docs: add week 4 step 1 requirements * feat: add searching by saved search keyword * chore: relocate files proper * feat: modify adapter to make clean code * feat: add image for marker * feat: add layout for displaying bottom sheet * feat: add parcelabel for easy to send data * feat: add displaying search result * refactor: modify class structure * feat: add error screen and reload button * feat: add saving and loading last position when app is closed, save last position when app is opened, load last position * 충남대 Android_김선규 4주차 Step2 수정 (kakao-tech-campus-2nd-step2#73) * style: rename variable name * feat: add viewModel and Repository for saving last position * refactor: classify in more detail * test: add android UI test * chore: add mockk test dependency * test: add ViewModel test * chore: add testOptions * test: modify android ui test --------- Co-authored-by: MyStoryG <[email protected]>
khyeonm
added a commit
to khyeonm/android-map-notification
that referenced
this pull request
Aug 1, 2024
* Initial commit * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Docs: Update README.md * Feat: Create item_view * Feat: Modify main view * Feat: Implement search list * Feat: Complete saved element view * Feat: Complete save action * Feat: Add persistent save function * 부산대 Android_김현민_2주차_과제_Step1 (kakao-tech-campus-2nd-step2#2) * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Design: Modify save element design * Update README.md * Initial commit * Fix: Fix Week2 error * Docs: Update README.md Step1 README * Feat: Add initial settings * Feat: Add Document data class * Feat: Add RetrofitService interface * Refactor: Delete DB code * Feat: Add search function using API * Feat: Separate CategoryGroupCode * Docs: Update step2 README.md * Feat: complete initial project setup * Feat: Add mapview and map function * Fix: resolve errors * Chore: Update network security configuration * Fix: Resolve windows emulator issue * Style: Update mapview design * 부산대 Android_김현민 3주차 과제 Step0 (kakao-tech-campus-2nd-step2#19) * Initial commit * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Docs: Update README.md * Feat: Create item_view * Feat: Modify main view * Feat: Implement search list * Feat: Complete saved element view * Feat: Complete save action * Feat: Add persistent save function * 부산대 Android_김현민_2주차_과제_Step1 (kakao-tech-campus-2nd-step2#2) * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Design: Modify save element design * Update README.md --------- Co-authored-by: MyStoryG <[email protected]> * Fix: Reflect feedback * Fix: Resolve error * Docs: Update README.md * Feat: Add location marker * Feat: Add camera movement function * Feat: Add bottom sheet dialog * Feat: Add initial camera location function * Refactor: Resolve initial camera issue and search issue * Feat: Add map error event * Design: Modify UI design * Refactor: Separate function and write annotations * Docs: Update README.md * Feat: Add save item click function * Feat: Add keyword search function * Update README.md --------- Co-authored-by: MyStoryG <[email protected]>
khyeonm
added a commit
to khyeonm/android-map-notification
that referenced
this pull request
Aug 1, 2024
* Initial commit * Initial commit * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Docs: Update README.md * Feat: Create item_view * Feat: Modify main view * Feat: Implement search list * Feat: Complete saved element view * Feat: Complete save action * Feat: Add persistent save function * 부산대 Android_김현민_2주차_과제_Step1 (kakao-tech-campus-2nd-step2#2) * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Design: Modify save element design * Update README.md * Initial commit * Fix: Fix Week2 error * Docs: Update README.md Step1 README * Feat: Add initial settings * Feat: Add Document data class * Feat: Add RetrofitService interface * Refactor: Delete DB code * Feat: Add search function using API * Feat: Separate CategoryGroupCode * Docs: Update step2 README.md * Feat: complete initial project setup * Feat: Add mapview and map function * Fix: resolve errors * Chore: Update network security configuration * Fix: Resolve windows emulator issue * Style: Update mapview design * 부산대 Android_김현민 3주차 과제 Step0 (kakao-tech-campus-2nd-step2#19) * Initial commit * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Docs: Update README.md * Feat: Create item_view * Feat: Modify main view * Feat: Implement search list * Feat: Complete saved element view * Feat: Complete save action * Feat: Add persistent save function * 부산대 Android_김현민_2주차_과제_Step1 (kakao-tech-campus-2nd-step2#2) * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Design: Modify save element design * Update README.md --------- Co-authored-by: MyStoryG <[email protected]> * Fix: Reflect feedback * Fix: Resolve error * 부산대 Android_김현민 4주차 과제 Step0 (kakao-tech-campus-2nd-step2#16) * Initial commit * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Docs: Update README.md * Feat: Create item_view * Feat: Modify main view * Feat: Implement search list * Feat: Complete saved element view * Feat: Complete save action * Feat: Add persistent save function * 부산대 Android_김현민_2주차_과제_Step1 (kakao-tech-campus-2nd-step2#2) * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Design: Modify save element design * Update README.md * Initial commit * Fix: Fix Week2 error * Docs: Update README.md Step1 README * Feat: Add initial settings * Feat: Add Document data class * Feat: Add RetrofitService interface * Refactor: Delete DB code * Feat: Add search function using API * Feat: Separate CategoryGroupCode * Docs: Update step2 README.md * Feat: complete initial project setup * Feat: Add mapview and map function * Fix: resolve errors * Chore: Update network security configuration * Fix: Resolve windows emulator issue * Style: Update mapview design * 부산대 Android_김현민 3주차 과제 Step0 (kakao-tech-campus-2nd-step2#19) * Initial commit * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Docs: Update README.md * Feat: Create item_view * Feat: Modify main view * Feat: Implement search list * Feat: Complete saved element view * Feat: Complete save action * Feat: Add persistent save function * 부산대 Android_김현민_2주차_과제_Step1 (kakao-tech-campus-2nd-step2#2) * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Design: Modify save element design * Update README.md --------- Co-authored-by: MyStoryG <[email protected]> * Fix: Reflect feedback * Fix: Resolve error --------- Co-authored-by: MyStoryG <[email protected]> * Docs: Update README.md * Feat: Add location marker * Feat: Add camera movement function * Feat: Add bottom sheet dialog * Feat: Add initial camera location function * Refactor: Resolve initial camera issue and search issue * Feat: Add map error event * Design: Modify UI design * Refactor: Separate function and write annotations * Docs: Update README.md * Feat: Add save item click function * Feat: Add keyword search function * Refactor: Reflect step1 feedback * Feat: Add dependencies * Test: Add map activity ui test * Test: Add main activity ui test * Test: Add main activity unit test * Test: Add map activity unit test * 부산대 Android_김현민 4주차 과제 Step1 (kakao-tech-campus-2nd-step2#33) * Initial commit * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Docs: Update README.md * Feat: Create item_view * Feat: Modify main view * Feat: Implement search list * Feat: Complete saved element view * Feat: Complete save action * Feat: Add persistent save function * 부산대 Android_김현민_2주차_과제_Step1 (kakao-tech-campus-2nd-step2#2) * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Design: Modify save element design * Update README.md * Initial commit * Fix: Fix Week2 error * Docs: Update README.md Step1 README * Feat: Add initial settings * Feat: Add Document data class * Feat: Add RetrofitService interface * Refactor: Delete DB code * Feat: Add search function using API * Feat: Separate CategoryGroupCode * Docs: Update step2 README.md * Feat: complete initial project setup * Feat: Add mapview and map function * Fix: resolve errors * Chore: Update network security configuration * Fix: Resolve windows emulator issue * Style: Update mapview design * 부산대 Android_김현민 3주차 과제 Step0 (kakao-tech-campus-2nd-step2#19) * Initial commit * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Docs: Update README.md * Feat: Create item_view * Feat: Modify main view * Feat: Implement search list * Feat: Complete saved element view * Feat: Complete save action * Feat: Add persistent save function * 부산대 Android_김현민_2주차_과제_Step1 (kakao-tech-campus-2nd-step2#2) * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Design: Modify save element design * Update README.md --------- Co-authored-by: MyStoryG <[email protected]> * Fix: Reflect feedback * Fix: Resolve error * Docs: Update README.md * Feat: Add location marker * Feat: Add camera movement function * Feat: Add bottom sheet dialog * Feat: Add initial camera location function * Refactor: Resolve initial camera issue and search issue * Feat: Add map error event * Design: Modify UI design * Refactor: Separate function and write annotations * Docs: Update README.md * Feat: Add save item click function * Feat: Add keyword search function * Update README.md --------- Co-authored-by: MyStoryG <[email protected]> * Fix: Fix conflict error * Chore: Add dependency and grouping --------- Co-authored-by: MyStoryG <[email protected]>
khyeonm
added a commit
to khyeonm/android-map-notification
that referenced
this pull request
Aug 1, 2024
* Initial commit * Initial commit * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Docs: Update README.md * Feat: Create item_view * Feat: Modify main view * Feat: Implement search list * Feat: Complete saved element view * Feat: Complete save action * Feat: Add persistent save function * 부산대 Android_김현민_2주차_과제_Step1 (kakao-tech-campus-2nd-step2#2) * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Design: Modify save element design * Update README.md * Initial commit * Fix: Fix Week2 error * Docs: Update README.md Step1 README * Feat: Add initial settings * Feat: Add Document data class * Feat: Add RetrofitService interface * Refactor: Delete DB code * Feat: Add search function using API * Feat: Separate CategoryGroupCode * Docs: Update step2 README.md * Feat: complete initial project setup * Feat: Add mapview and map function * Fix: resolve errors * Chore: Update network security configuration * Fix: Resolve windows emulator issue * Style: Update mapview design * 부산대 Android_김현민 3주차 과제 Step0 (kakao-tech-campus-2nd-step2#19) * Initial commit * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Docs: Update README.md * Feat: Create item_view * Feat: Modify main view * Feat: Implement search list * Feat: Complete saved element view * Feat: Complete save action * Feat: Add persistent save function * 부산대 Android_김현민_2주차_과제_Step1 (kakao-tech-campus-2nd-step2#2) * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Design: Modify save element design * Update README.md --------- Co-authored-by: MyStoryG <[email protected]> * Fix: Reflect feedback * Fix: Resolve error * 부산대 Android_김현민 4주차 과제 Step0 (kakao-tech-campus-2nd-step2#16) * Initial commit * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Docs: Update README.md * Feat: Create item_view * Feat: Modify main view * Feat: Implement search list * Feat: Complete saved element view * Feat: Complete save action * Feat: Add persistent save function * 부산대 Android_김현민_2주차_과제_Step1 (kakao-tech-campus-2nd-step2#2) * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Design: Modify save element design * Update README.md * Initial commit * Fix: Fix Week2 error * Docs: Update README.md Step1 README * Feat: Add initial settings * Feat: Add Document data class * Feat: Add RetrofitService interface * Refactor: Delete DB code * Feat: Add search function using API * Feat: Separate CategoryGroupCode * Docs: Update step2 README.md * Feat: complete initial project setup * Feat: Add mapview and map function * Fix: resolve errors * Chore: Update network security configuration * Fix: Resolve windows emulator issue * Style: Update mapview design * 부산대 Android_김현민 3주차 과제 Step0 (kakao-tech-campus-2nd-step2#19) * Initial commit * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Docs: Update README.md * Feat: Create item_view * Feat: Modify main view * Feat: Implement search list * Feat: Complete saved element view * Feat: Complete save action * Feat: Add persistent save function * 부산대 Android_김현민_2주차_과제_Step1 (kakao-tech-campus-2nd-step2#2) * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Design: Modify save element design * Update README.md --------- Co-authored-by: MyStoryG <[email protected]> * Fix: Reflect feedback * Fix: Resolve error --------- Co-authored-by: MyStoryG <[email protected]> * Docs: Update README.md * Feat: Add location marker * Feat: Add camera movement function * Feat: Add bottom sheet dialog * Feat: Add initial camera location function * Refactor: Resolve initial camera issue and search issue * Feat: Add map error event * Design: Modify UI design * Refactor: Separate function and write annotations * Docs: Update README.md * Feat: Add save item click function * Feat: Add keyword search function * Refactor: Reflect step1 feedback * Feat: Add dependencies * Test: Add map activity ui test * Test: Add main activity ui test * Test: Add main activity unit test * Test: Add map activity unit test * 부산대 Android_김현민 4주차 과제 Step1 (kakao-tech-campus-2nd-step2#33) * Initial commit * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Docs: Update README.md * Feat: Create item_view * Feat: Modify main view * Feat: Implement search list * Feat: Complete saved element view * Feat: Complete save action * Feat: Add persistent save function * 부산대 Android_김현민_2주차_과제_Step1 (kakao-tech-campus-2nd-step2#2) * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Design: Modify save element design * Update README.md * Initial commit * Fix: Fix Week2 error * Docs: Update README.md Step1 README * Feat: Add initial settings * Feat: Add Document data class * Feat: Add RetrofitService interface * Refactor: Delete DB code * Feat: Add search function using API * Feat: Separate CategoryGroupCode * Docs: Update step2 README.md * Feat: complete initial project setup * Feat: Add mapview and map function * Fix: resolve errors * Chore: Update network security configuration * Fix: Resolve windows emulator issue * Style: Update mapview design * 부산대 Android_김현민 3주차 과제 Step0 (kakao-tech-campus-2nd-step2#19) * Initial commit * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Docs: Update README.md * Feat: Create item_view * Feat: Modify main view * Feat: Implement search list * Feat: Complete saved element view * Feat: Complete save action * Feat: Add persistent save function * 부산대 Android_김현민_2주차_과제_Step1 (kakao-tech-campus-2nd-step2#2) * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Design: Modify save element design * Update README.md --------- Co-authored-by: MyStoryG <[email protected]> * Fix: Reflect feedback * Fix: Resolve error * Docs: Update README.md * Feat: Add location marker * Feat: Add camera movement function * Feat: Add bottom sheet dialog * Feat: Add initial camera location function * Refactor: Resolve initial camera issue and search issue * Feat: Add map error event * Design: Modify UI design * Refactor: Separate function and write annotations * Docs: Update README.md * Feat: Add save item click function * Feat: Add keyword search function * Update README.md --------- Co-authored-by: MyStoryG <[email protected]> * Fix: Fix conflict error * Chore: Add dependency and grouping * Chore: Edit grouping * Refactor: Change database to Room * Fix: Resolve data integrity error * Refactor: Apply dependency injection dependency injection about network * Refactor: Apply dependency injection dependency injection about map utility * Refactor: Apply dependency injection dependency injection about map search service * Chore: Edit grouping * Refactor: Apply dependency injection dependency injection about search save service * Refactor: Apply dependency injection dependency injection about bottomsheet * Fix: Remove test code error Resolve errors caused by code modification during refactoring process --------- Co-authored-by: MyStoryG <[email protected]>
khyeonm
added a commit
to khyeonm/android-map-notification
that referenced
this pull request
Aug 2, 2024
* Initial commit * Initial commit * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Docs: Update README.md * Feat: Create item_view * Feat: Modify main view * Feat: Implement search list * Feat: Complete saved element view * Feat: Complete save action * Feat: Add persistent save function * 부산대 Android_김현민_2주차_과제_Step1 (kakao-tech-campus-2nd-step2#2) * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Design: Modify save element design * Update README.md * Initial commit * Fix: Fix Week2 error * Docs: Update README.md Step1 README * Feat: Add initial settings * Feat: Add Document data class * Feat: Add RetrofitService interface * Refactor: Delete DB code * Feat: Add search function using API * Feat: Separate CategoryGroupCode * Docs: Update step2 README.md * Feat: complete initial project setup * Feat: Add mapview and map function * Fix: resolve errors * Chore: Update network security configuration * Fix: Resolve windows emulator issue * Style: Update mapview design * 부산대 Android_김현민 3주차 과제 Step0 (kakao-tech-campus-2nd-step2#19) * Initial commit * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Docs: Update README.md * Feat: Create item_view * Feat: Modify main view * Feat: Implement search list * Feat: Complete saved element view * Feat: Complete save action * Feat: Add persistent save function * 부산대 Android_김현민_2주차_과제_Step1 (kakao-tech-campus-2nd-step2#2) * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Design: Modify save element design * Update README.md --------- Co-authored-by: MyStoryG <[email protected]> * Fix: Reflect feedback * Fix: Resolve error * 부산대 Android_김현민 4주차 과제 Step0 (kakao-tech-campus-2nd-step2#16) * Initial commit * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Docs: Update README.md * Feat: Create item_view * Feat: Modify main view * Feat: Implement search list * Feat: Complete saved element view * Feat: Complete save action * Feat: Add persistent save function * 부산대 Android_김현민_2주차_과제_Step1 (kakao-tech-campus-2nd-step2#2) * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Design: Modify save element design * Update README.md * Initial commit * Fix: Fix Week2 error * Docs: Update README.md Step1 README * Feat: Add initial settings * Feat: Add Document data class * Feat: Add RetrofitService interface * Refactor: Delete DB code * Feat: Add search function using API * Feat: Separate CategoryGroupCode * Docs: Update step2 README.md * Feat: complete initial project setup * Feat: Add mapview and map function * Fix: resolve errors * Chore: Update network security configuration * Fix: Resolve windows emulator issue * Style: Update mapview design * 부산대 Android_김현민 3주차 과제 Step0 (kakao-tech-campus-2nd-step2#19) * Initial commit * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Docs: Update README.md * Feat: Create item_view * Feat: Modify main view * Feat: Implement search list * Feat: Complete saved element view * Feat: Complete save action * Feat: Add persistent save function * 부산대 Android_김현민_2주차_과제_Step1 (kakao-tech-campus-2nd-step2#2) * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Design: Modify save element design * Update README.md --------- Co-authored-by: MyStoryG <[email protected]> * Fix: Reflect feedback * Fix: Resolve error --------- Co-authored-by: MyStoryG <[email protected]> * Docs: Update README.md * Feat: Add location marker * Feat: Add camera movement function * Feat: Add bottom sheet dialog * Feat: Add initial camera location function * Refactor: Resolve initial camera issue and search issue * Feat: Add map error event * Design: Modify UI design * Refactor: Separate function and write annotations * Docs: Update README.md * Feat: Add save item click function * Feat: Add keyword search function * Refactor: Reflect step1 feedback * Initial commit * Feat: Add dependencies * Test: Add map activity ui test * Test: Add main activity ui test * Test: Add main activity unit test * Test: Add map activity unit test * 부산대 Android_김현민 4주차 과제 Step1 (kakao-tech-campus-2nd-step2#33) * Initial commit * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Docs: Update README.md * Feat: Create item_view * Feat: Modify main view * Feat: Implement search list * Feat: Complete saved element view * Feat: Complete save action * Feat: Add persistent save function * 부산대 Android_김현민_2주차_과제_Step1 (kakao-tech-campus-2nd-step2#2) * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Design: Modify save element design * Update README.md * Initial commit * Fix: Fix Week2 error * Docs: Update README.md Step1 README * Feat: Add initial settings * Feat: Add Document data class * Feat: Add RetrofitService interface * Refactor: Delete DB code * Feat: Add search function using API * Feat: Separate CategoryGroupCode * Docs: Update step2 README.md * Feat: complete initial project setup * Feat: Add mapview and map function * Fix: resolve errors * Chore: Update network security configuration * Fix: Resolve windows emulator issue * Style: Update mapview design * 부산대 Android_김현민 3주차 과제 Step0 (kakao-tech-campus-2nd-step2#19) * Initial commit * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Docs: Update README.md * Feat: Create item_view * Feat: Modify main view * Feat: Implement search list * Feat: Complete saved element view * Feat: Complete save action * Feat: Add persistent save function * 부산대 Android_김현민_2주차_과제_Step1 (kakao-tech-campus-2nd-step2#2) * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Design: Modify save element design * Update README.md --------- Co-authored-by: MyStoryG <[email protected]> * Fix: Reflect feedback * Fix: Resolve error * Docs: Update README.md * Feat: Add location marker * Feat: Add camera movement function * Feat: Add bottom sheet dialog * Feat: Add initial camera location function * Refactor: Resolve initial camera issue and search issue * Feat: Add map error event * Design: Modify UI design * Refactor: Separate function and write annotations * Docs: Update README.md * Feat: Add save item click function * Feat: Add keyword search function * Update README.md --------- Co-authored-by: MyStoryG <[email protected]> * Fix: Fix conflict error * Chore: Add dependency and grouping * 부산대 Android_김현민 5주차 과제 Step0 (kakao-tech-campus-2nd-step2#6) * Initial commit * Initial commit * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Docs: Update README.md * Feat: Create item_view * Feat: Modify main view * Feat: Implement search list * Feat: Complete saved element view * Feat: Complete save action * Feat: Add persistent save function * 부산대 Android_김현민_2주차_과제_Step1 (kakao-tech-campus-2nd-step2#2) * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Design: Modify save element design * Update README.md * Initial commit * Fix: Fix Week2 error * Docs: Update README.md Step1 README * Feat: Add initial settings * Feat: Add Document data class * Feat: Add RetrofitService interface * Refactor: Delete DB code * Feat: Add search function using API * Feat: Separate CategoryGroupCode * Docs: Update step2 README.md * Feat: complete initial project setup * Feat: Add mapview and map function * Fix: resolve errors * Chore: Update network security configuration * Fix: Resolve windows emulator issue * Style: Update mapview design * 부산대 Android_김현민 3주차 과제 Step0 (kakao-tech-campus-2nd-step2#19) * Initial commit * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Docs: Update README.md * Feat: Create item_view * Feat: Modify main view * Feat: Implement search list * Feat: Complete saved element view * Feat: Complete save action * Feat: Add persistent save function * 부산대 Android_김현민_2주차_과제_Step1 (kakao-tech-campus-2nd-step2#2) * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Design: Modify save element design * Update README.md --------- Co-authored-by: MyStoryG <[email protected]> * Fix: Reflect feedback * Fix: Resolve error * 부산대 Android_김현민 4주차 과제 Step0 (kakao-tech-campus-2nd-step2#16) * Initial commit * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Docs: Update README.md * Feat: Create item_view * Feat: Modify main view * Feat: Implement search list * Feat: Complete saved element view * Feat: Complete save action * Feat: Add persistent save function * 부산대 Android_김현민_2주차_과제_Step1 (kakao-tech-campus-2nd-step2#2) * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Design: Modify save element design * Update README.md * Initial commit * Fix: Fix Week2 error * Docs: Update README.md Step1 README * Feat: Add initial settings * Feat: Add Document data class * Feat: Add RetrofitService interface * Refactor: Delete DB code * Feat: Add search function using API * Feat: Separate CategoryGroupCode * Docs: Update step2 README.md * Feat: complete initial project setup * Feat: Add mapview and map function * Fix: resolve errors * Chore: Update network security configuration * Fix: Resolve windows emulator issue * Style: Update mapview design * 부산대 Android_김현민 3주차 과제 Step0 (kakao-tech-campus-2nd-step2#19) * Initial commit * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Docs: Update README.md * Feat: Create item_view * Feat: Modify main view * Feat: Implement search list * Feat: Complete saved element view * Feat: Complete save action * Feat: Add persistent save function * 부산대 Android_김현민_2주차_과제_Step1 (kakao-tech-campus-2nd-step2#2) * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Design: Modify save element design * Update README.md --------- Co-authored-by: MyStoryG <[email protected]> * Fix: Reflect feedback * Fix: Resolve error --------- Co-authored-by: MyStoryG <[email protected]> * Docs: Update README.md * Feat: Add location marker * Feat: Add camera movement function * Feat: Add bottom sheet dialog * Feat: Add initial camera location function * Refactor: Resolve initial camera issue and search issue * Feat: Add map error event * Design: Modify UI design * Refactor: Separate function and write annotations * Docs: Update README.md * Feat: Add save item click function * Feat: Add keyword search function * Refactor: Reflect step1 feedback * Feat: Add dependencies * Test: Add map activity ui test * Test: Add main activity ui test * Test: Add main activity unit test * Test: Add map activity unit test * 부산대 Android_김현민 4주차 과제 Step1 (kakao-tech-campus-2nd-step2#33) * Initial commit * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Docs: Update README.md * Feat: Create item_view * Feat: Modify main view * Feat: Implement search list * Feat: Complete saved element view * Feat: Complete save action * Feat: Add persistent save function * 부산대 Android_김현민_2주차_과제_Step1 (kakao-tech-campus-2nd-step2#2) * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Design: Modify save element design * Update README.md * Initial commit * Fix: Fix Week2 error * Docs: Update README.md Step1 README * Feat: Add initial settings * Feat: Add Document data class * Feat: Add RetrofitService interface * Refactor: Delete DB code * Feat: Add search function using API * Feat: Separate CategoryGroupCode * Docs: Update step2 README.md * Feat: complete initial project setup * Feat: Add mapview and map function * Fix: resolve errors * Chore: Update network security configuration * Fix: Resolve windows emulator issue * Style: Update mapview design * 부산대 Android_김현민 3주차 과제 Step0 (kakao-tech-campus-2nd-step2#19) * Initial commit * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Docs: Update README.md * Feat: Create item_view * Feat: Modify main view * Feat: Implement search list * Feat: Complete saved element view * Feat: Complete save action * Feat: Add persistent save function * 부산대 Android_김현민_2주차_과제_Step1 (kakao-tech-campus-2nd-step2#2) * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Design: Modify save element design * Update README.md --------- Co-authored-by: MyStoryG <[email protected]> * Fix: Reflect feedback * Fix: Resolve error * Docs: Update README.md * Feat: Add location marker * Feat: Add camera movement function * Feat: Add bottom sheet dialog * Feat: Add initial camera location function * Refactor: Resolve initial camera issue and search issue * Feat: Add map error event * Design: Modify UI design * Refactor: Separate function and write annotations * Docs: Update README.md * Feat: Add save item click function * Feat: Add keyword search function * Update README.md --------- Co-authored-by: MyStoryG <[email protected]> * Fix: Fix conflict error * Chore: Add dependency and grouping --------- Co-authored-by: MyStoryG <[email protected]> * Chore: Edit grouping * Refactor: Change database to Room * Fix: Resolve data integrity error * Refactor: Apply dependency injection dependency injection about network * Refactor: Apply dependency injection dependency injection about map utility * Refactor: Apply dependency injection dependency injection about map search service * Chore: Edit grouping * Refactor: Apply dependency injection dependency injection about search save service * Refactor: Apply dependency injection dependency injection about bottomsheet * Fix: Remove test code error Resolve errors caused by code modification during refactoring process * Refactor: Reflect step1 feedback * Chore: Add initial settings * Refactor: Apply databinding in MainActivity * Refactor: Apply MVVM in error activity Utilize LiveData and DataBinding * 부산대 Android_김현민 5주차 과제 Step1 (kakao-tech-campus-2nd-step2#25) * Initial commit * Initial commit * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Docs: Update README.md * Feat: Create item_view * Feat: Modify main view * Feat: Implement search list * Feat: Complete saved element view * Feat: Complete save action * Feat: Add persistent save function * 부산대 Android_김현민_2주차_과제_Step1 (kakao-tech-campus-2nd-step2#2) * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Design: Modify save element design * Update README.md * Initial commit * Fix: Fix Week2 error * Docs: Update README.md Step1 README * Feat: Add initial settings * Feat: Add Document data class * Feat: Add RetrofitService interface * Refactor: Delete DB code * Feat: Add search function using API * Feat: Separate CategoryGroupCode * Docs: Update step2 README.md * Feat: complete initial project setup * Feat: Add mapview and map function * Fix: resolve errors * Chore: Update network security configuration * Fix: Resolve windows emulator issue * Style: Update mapview design * 부산대 Android_김현민 3주차 과제 Step0 (kakao-tech-campus-2nd-step2#19) * Initial commit * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Docs: Update README.md * Feat: Create item_view * Feat: Modify main view * Feat: Implement search list * Feat: Complete saved element view * Feat: Complete save action * Feat: Add persistent save function * 부산대 Android_김현민_2주차_과제_Step1 (kakao-tech-campus-2nd-step2#2) * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Design: Modify save element design * Update README.md --------- Co-authored-by: MyStoryG <[email protected]> * Fix: Reflect feedback * Fix: Resolve error * 부산대 Android_김현민 4주차 과제 Step0 (kakao-tech-campus-2nd-step2#16) * Initial commit * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Docs: Update README.md * Feat: Create item_view * Feat: Modify main view * Feat: Implement search list * Feat: Complete saved element view * Feat: Complete save action * Feat: Add persistent save function * 부산대 Android_김현민_2주차_과제_Step1 (kakao-tech-campus-2nd-step2#2) * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Design: Modify save element design * Update README.md * Initial commit * Fix: Fix Week2 error * Docs: Update README.md Step1 README * Feat: Add initial settings * Feat: Add Document data class * Feat: Add RetrofitService interface * Refactor: Delete DB code * Feat: Add search function using API * Feat: Separate CategoryGroupCode * Docs: Update step2 README.md * Feat: complete initial project setup * Feat: Add mapview and map function * Fix: resolve errors * Chore: Update network security configuration * Fix: Resolve windows emulator issue * Style: Update mapview design * 부산대 Android_김현민 3주차 과제 Step0 (kakao-tech-campus-2nd-step2#19) * Initial commit * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Docs: Update README.md * Feat: Create item_view * Feat: Modify main view * Feat: Implement search list * Feat: Complete saved element view * Feat: Complete save action * Feat: Add persistent save function * 부산대 Android_김현민_2주차_과제_Step1 (kakao-tech-campus-2nd-step2#2) * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Design: Modify save element design * Update README.md --------- Co-authored-by: MyStoryG <[email protected]> * Fix: Reflect feedback * Fix: Resolve error --------- Co-authored-by: MyStoryG <[email protected]> * Docs: Update README.md * Feat: Add location marker * Feat: Add camera movement function * Feat: Add bottom sheet dialog * Feat: Add initial camera location function * Refactor: Resolve initial camera issue and search issue * Feat: Add map error event * Design: Modify UI design * Refactor: Separate function and write annotations * Docs: Update README.md * Feat: Add save item click function * Feat: Add keyword search function * Refactor: Reflect step1 feedback * Feat: Add dependencies * Test: Add map activity ui test * Test: Add main activity ui test * Test: Add main activity unit test * Test: Add map activity unit test * 부산대 Android_김현민 4주차 과제 Step1 (kakao-tech-campus-2nd-step2#33) * Initial commit * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Docs: Update README.md * Feat: Create item_view * Feat: Modify main view * Feat: Implement search list * Feat: Complete saved element view * Feat: Complete save action * Feat: Add persistent save function * 부산대 Android_김현민_2주차_과제_Step1 (kakao-tech-campus-2nd-step2#2) * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Design: Modify save element design * Update README.md * Initial commit * Fix: Fix Week2 error * Docs: Update README.md Step1 README * Feat: Add initial settings * Feat: Add Document data class * Feat: Add RetrofitService interface * Refactor: Delete DB code * Feat: Add search function using API * Feat: Separate CategoryGroupCode * Docs: Update step2 README.md * Feat: complete initial project setup * Feat: Add mapview and map function * Fix: resolve errors * Chore: Update network security configuration * Fix: Resolve windows emulator issue * Style: Update mapview design * 부산대 Android_김현민 3주차 과제 Step0 (kakao-tech-campus-2nd-step2#19) * Initial commit * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Docs: Update README.md * Feat: Create item_view * Feat: Modify main view * Feat: Implement search list * Feat: Complete saved element view * Feat: Complete save action * Feat: Add persistent save function * 부산대 Android_김현민_2주차_과제_Step1 (kakao-tech-campus-2nd-step2#2) * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Design: Modify save element design * Update README.md --------- Co-authored-by: MyStoryG <[email protected]> * Fix: Reflect feedback * Fix: Resolve error * Docs: Update README.md * Feat: Add location marker * Feat: Add camera movement function * Feat: Add bottom sheet dialog * Feat: Add initial camera location function * Refactor: Resolve initial camera issue and search issue * Feat: Add map error event * Design: Modify UI design * Refactor: Separate function and write annotations * Docs: Update README.md * Feat: Add save item click function * Feat: Add keyword search function * Update README.md --------- Co-authored-by: MyStoryG <[email protected]> * Fix: Fix conflict error * Chore: Add dependency and grouping * Chore: Edit grouping * Refactor: Change database to Room * Fix: Resolve data integrity error * Refactor: Apply dependency injection dependency injection about network * Refactor: Apply dependency injection dependency injection about map utility * Refactor: Apply dependency injection dependency injection about map search service * Chore: Edit grouping * Refactor: Apply dependency injection dependency injection about search save service * Refactor: Apply dependency injection dependency injection about bottomsheet * Fix: Remove test code error Resolve errors caused by code modification during refactoring process --------- Co-authored-by: MyStoryG <[email protected]> * Refactor: Change asynchronous to coroutine * Refactor: Apply MVVM in map activity Utilize LiveData and DataBinding * Chore: Modify error activity code * Refactor: Apply MVVM in main activity Utilize LiveData and DataBinding * Chore: Prepare step0 --------- Co-authored-by: MyStoryG <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 멘토님!
6주차 1단계 과제 제출합니다.
이번 주차 1단계 과제의 경우, 강의와 강의 자료가 큰 도움이 되어서 비교적 수월하게 진행한 거 같습니다.. !!
오늘도 좋은 리뷰 감사합니다 :)
1단계 커밋 모음
https://github.com/kakao-tech-campus-2nd-step2/android-map-notification/pull/33/files/ff3f7cbb3cacf5bee14fec17688072b08093f36e..77fd1dc52ced1d40a4657f1be6e01f8409b21ed0
중점적으로 봐주셨으면 하는 부분
실행 사진
[serviceState가 ON_SERVICE가 아닌 경우]
[serviceState가 ON_SERVICE인 경우]